Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set first day of week #31

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fritz-net
Copy link

@fritz-net fritz-net commented Jan 4, 2024

@SteffoSpieler
Copy link

SteffoSpieler commented Feb 25, 2024

This pull request also includes the pull request for Support more than 5 colors. Also it adds the package-lock.json file, which isn't included in the repository currently. (I don't know if this is intended or not, I'm neither the maintainer, nor do I use this package actively myself.)

But appart from these, I'd love to see this merged.

@fritz-net
Copy link
Author

@SteffoSpieler thanks for the review.
The other PR is included since I forked for this feature from my main and not the one in the original, totally missed that.

I would create a different branch and cherry pic the related changes if the Maintainer is willing to merge it in the first place. ( cherry picking resulted in merge conflicts since I changed the constructor in both PRs I think)

@fritz-net
Copy link
Author

as far as I found out package-lock.json should be checked in:
https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants