-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fix #88
Merged
Merged
CI fix #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repos specific commit
yohanelly95
requested review from
hrishikeshio,
ashish10677,
rajkharvar,
SamAg19 and
Yashk767
September 19, 2024 08:12
ashish10677
approved these changes
Sep 19, 2024
CI is expected to fail @yohanelly95 ? |
yes currently CI will fail |
rajkharvar
approved these changes
Sep 19, 2024
Yashk767
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Fix the CI
Description
There is a warning that checking out to forked repos branches commit, we use initially used
pull_request_target
as the trigger for pull requests created tomaster
branch. But the context of the test was run on the forked repos commit. Now this does not happen automatically when using theactions/setup-node@v3
action, it instead runs the test in the merge commit to master ie, in context to master. So we get afatal: detected dubious ownership in repository at
error..
What is expected:
.
Changes:
Changing the trigger to
pull_request
and checking out to the forked repos commit then continuing with the test.Type of change
Please mark the options that apply to this PR.
Checklist: