Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix #88

Merged
merged 12 commits into from
Sep 20, 2024
Merged

CI fix #88

merged 12 commits into from
Sep 20, 2024

Conversation

yohanelly95
Copy link
Member

@yohanelly95 yohanelly95 commented Sep 19, 2024


name: Fix the CI

Description

There is a warning that checking out to forked repos branches commit, we use initially used pull_request_target as the trigger for pull requests created to master branch. But the context of the test was run on the forked repos commit. Now this does not happen automatically when using the actions/setup-node@v3 action, it instead runs the test in the merge commit to master ie, in context to master. So we get a fatal: detected dubious ownership in repository at error.
Screenshot 2024-09-19 at 1 45 37 PM.

What is expected:
Screenshot 2024-09-19 at 1 46 20 PM.

Changes:

Changing the trigger to pull_request and checking out to the forked repos commit then continuing with the test.

Type of change

Please mark the options that apply to this PR.

  • New job
  • New collection
  • API is valid, example API response:
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code and it conforms with the formatting
  • I have added tests that prove my Job/Collection is valid and all tests are passing
  • I have made corresponding changes to the documentation

@yohanelly95 yohanelly95 changed the title Ci fix CI fix Sep 19, 2024
@ashish10677
Copy link
Member

CI is expected to fail @yohanelly95 ?

@yohanelly95
Copy link
Member Author

CI is expected to fail @yohanelly95 ?

yes currently CI will fail

@hrishikeshio hrishikeshio merged commit 68aca25 into razor-network:master Sep 20, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants