fix: while updating role, do full refresh of permissions #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently while updating role, frontier used to identify the deleted permissions from role and only remove them which are needed. One problem with this is if in case someone manually modifies such roles and the permissions gets out of sync, it will not try to correct them. Now it deletes all existing permissions and create the new requested on every update call. Signed-off-by: Kush Sharma <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 11707035493Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently while updating role, frontier used to identify the deleted permissions from role and only remove them which are needed. One problem with this is if in case someone manually modifies such roles and the permissions gets out of sync, it will not try to correct them. Now it deletes all existing permissions and create the new requested on every update call.