chore: identify APIs that can be moved to parent component #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 10768126423Details
💛 - Coveralls |
paanSinghCoder
changed the title
|
@paanSinghCoder Do we still need this? Can we move relevant changes recommended here to a task and close this? |
|
@anujk14 IMO these are not must have changes thus can be treated as very low priority and can even be discarded. |
@paanSinghCoder Since we had put in effort in identifying these instances, I believe we should add this to a task so that we don't end up spending time again on identifying the same thing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify API calls which can be potentially moved to top level.