Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add itemlink module #372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add itemlink module #372

wants to merge 2 commits into from

Conversation

vstumpf
Copy link
Member

@vstumpf vstumpf commented Oct 22, 2023

This adds a module to parse itemlinks, presenting a page with the info of the item link.
image

@Akkarinage
Copy link
Member

Has anyone tested this or have any thoughts?

Akkarinage
Akkarinage reviewed Mar 16, 2024
View reviewed changes
Copy link
Member

@Akkarinage Akkarinage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but I don't think most people are going to know how to generate a link. Perhaps throw an example URL at the top of modules/itemlink/index.php as a starting point?

themes/default/itemlink/emptysocket.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can images go into the img/ dir please?

themes/default/itemlink/nosocket.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can images go into the img/ dir please?

@Akkarinage Akkarinage added Component: Framework Awaiting Update Pending review changes that the author needs to action/resolve before merging labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkarinage Akkarinage Akkarinage left review comments

Assignees
No one assigned
Labels
Awaiting Update Pending review changes that the author needs to action/resolve before merging Component: Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstumpf @Akkarinage