Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added page for listing vending items #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added page for listing vending items #193

wants to merge 1 commit into from

Conversation

aries-delossantos
Copy link
Contributor

@aries-delossantos aries-delossantos mentioned this pull request Jun 20, 2018
Open
sanasol
sanasol reviewed Mar 31, 2019
View reviewed changes
Copy link
Member

@sanasol sanasol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should replace viewshop page with this one then? Since it's same functionality in 2 pages.
Something like add merchant filter to items page and link index page with vendings to search by merchant on items page.
And then remove viewshop page.

@Akkarinage
Copy link
Member

I'm inclined to agree with @S-anasol

Daegaladh
Daegaladh suggested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@Daegaladh Daegaladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agrre with Akkarin and S-anasol.
Also, please replace all hardcoded texts with lang variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanasol sanasol sanasol left review comments

@Daegaladh Daegaladh Daegaladh requested changes

@Akkarinage Akkarinage Awaiting requested review from Akkarinage

@cydh cydh Awaiting requested review from cydh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aries-delossantos @Akkarinage @sanasol @Daegaladh