Update for Swift 3 and xCode 8 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When contributing developers will need to run pod install before opening the examples.
Updated source code and build settings to compile using Swift 3 and xCode 8.
API has been updated to more closely follow the Swift API Design Guidelines. The setTheme() function has been set to have a discardable result to reduce warnings.
|
Hi! Thanks for all the effort you put here :). I was hopping on closing #1 before moving to 1.0, but I don't think I will be able to do it any time soon. So, I will merge your changes :). |
|
I'll make a new release this week. |
|
@rudedogg Hey, I just sent you an invitation to become a collaborator. It would be nice if you can join as I have very little time to work on this project right now. |
|
@raspu I'd love to. I'm doing some freelance work now, but I'd love to work on it in the near future, and can help with the admin stuff. |
|
@rudedogg Thanks! I really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes the API a little bit, which I mentioned in
CHANGELOG.md. Because this isn't backwards compatible I bumped the version of the podspec to1.0.0.The pod lint passes without warnings, and the examples appear to work well. Let me know what you think, or if you'd like me to make any changes.
Thanks!