Mainline BE #31
Merged
Mainline BE #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking over from #30 by using a compiler flag to disable the packed struct fields warning. |
|
Do you happen to know why 73ee880 wasn't needed for you ? |
No idea. I never got any compiler error messages in gcc/clang. Did you get one in your builds? |
Yes I do with
|
Replace the existing getOutputSize() private function with an equivalent helper that fixes the config structure in-place as there is only ever a single caller for it. Signed-off-by: Naushir Patuck <[email protected]>
This is needed for when we start using the UAPI kernel headers which use "__attribute__((packed))" to force structure packing as required by the kernel. The compiler complains about taking a possibly unaligned address of a packed structure even though the structure has been hand packed. Signed-off-by: Naushir Patuck <[email protected]>
Update the pisp_be_config.h and pisp_common.h headers from v11 mainline patch series at: https://lore.kernel.org/all/[email protected]/ Plus additional fixes on top sent at: https://lore.kernel.org/linux-media/[email protected]/ Signed-off-by: Jacopo Mondi <[email protected]>
The mainline header now uses uppercase identifiers for the image format macros. Adjust them in libpisp code. Signed-off-by: Jacopo Mondi <[email protected]>
Now that pisp_common.h doesn't include pips_types.h (which will be removed) the single files using C standard int types should include the header explicitly. Signed-off-by: Jacopo Mondi <[email protected]>
The 'abs()' symbol is undefined. Use the implementation from the C++ STL. Signed-off-by: Jacopo Mondi <[email protected]>
The pips_types.h header has been absorbed in pisp_common.h by the mainline driver version. Drop it from libpisp as well. Signed-off-by: Jacopo Mondi <[email protected]>
The mainline version of pisp_be_config.h header defines the 'num_tiles' member of 'struct pisp_be_tiles_config' as an unsigned 32-bit value. Use an unsigned integer as loop variable to avoid the following compilation error: error: comparison of integer expressions of different signedness Signed-off-by: Jacopo Mondi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.