Some backend changes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidplowman and @njhollinghurst we won't merge this yet, but just a heads-up. |
These cannot be used to make a derived class. Also change the protected section to private. Signed-off-by: Naushir Patuck <[email protected]>
To allow the BackEnd and FrontEnd objects to be safely shared between processes, it must be a standard layout type. Add a static_assert to ensure this is the case. Remove the const reference PiSPVariant members from both BackEnd and FrontEnd and replace with a const PiSPVariant member. Remove all BackEnd default config std::map types. These are replaced by std::vector<std::pair<.,.>> types which are standard layout types. Signed-off-by: Naushir Patuck <[email protected]>
Remove the various extras fields from struct pisp_be_config. These fields are not used by the driver nor the hardware, so do not belong in this structure. Signed-off-by: Naushir Patuck <[email protected]>
These are never used by either the kernel driver or libpisp. Signed-off-by: Naushir Patuck <[email protected]>
|
@davidplowman and @njhollinghurst This change removes the extra fields from the BE config structure, but keeps backward compatibility. The "standard layout" change is needed for libcamera. |
|
Sadly these changes will break the simulator and the run-test. These will need fixing up soon... |
|
LGTM. The padding is a useful kludge for compatibility, e.g. for people running an older image who might need to upgrade their kernel for some other reason. I can help with the simulator/HAL changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will break the kernel driver if not updated together.