-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no ci] Add empty-columns section to the libcudf developer guide #17183
base: branch-24.12
Are you sure you want to change the base?
Conversation
# Empty Columns | ||
|
||
The libcudf columns support empty, typed content. These columns have no data and no validity mask. | ||
Empty strings columns may or may not contain a child offsets column. If is undefined behavior (UB) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty strings columns may or may not contain a child offsets column. If is undefined behavior (UB) | |
Empty strings columns may or may not contain a child offsets column. It is undefined behavior (UB) |
Use the `cudf::make_empty_column()` to create fixed-width and strings columns. | ||
Use the `cudf::empty_like()` to create an empty column from an existing `cudf::column_view`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the `cudf::make_empty_column()` to create fixed-width and strings columns. | |
Use the `cudf::empty_like()` to create an empty column from an existing `cudf::column_view`. | |
Use `cudf::make_empty_column()` to create fixed-width and strings columns. | |
Use `cudf::empty_like()` to create an empty column from an existing `cudf::column_view`. |
|
||
The libcudf columns support empty, typed content. These columns have no data and no validity mask. | ||
Empty strings columns may or may not contain a child offsets column. If is undefined behavior (UB) | ||
to access the children of an empty strings column. Nested columns like lists and structs may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any behavior like this in lists columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean accessing children for an empty lists column?
I think the next sentence describes lists and structs may have children.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondering whether a lists column created with empty_like()
always has an offset child column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it does but it would probably be prudent to say accessing it UB as well.
Description
Adds a section on
Empty Columns
to the libcudf DEVELOPER_GUIDEChecklist