[no ci] Add empty-columns section to the libcudf developer guide #17183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
bdice
reviewed
Oct 25, 2024
| # Empty Columns | ||
|
|
||
| The libcudf columns support empty, typed content. These columns have no data and no validity mask. | ||
| Empty strings columns may or may not contain a child offsets column. If is undefined behavior (UB) |
There was a problem hiding this comment.
Suggested change
| Empty strings columns may or may not contain a child offsets column. If is undefined behavior (UB) | |
| Empty strings columns may or may not contain a child offsets column. It is undefined behavior (UB) |
bdice
reviewed
Oct 25, 2024
Comment on lines
1493
to
1494
| Use the `cudf::make_empty_column()` to create fixed-width and strings columns. | ||
| Use the `cudf::empty_like()` to create an empty column from an existing `cudf::column_view`. |
There was a problem hiding this comment.
Suggested change
| Use the `cudf::make_empty_column()` to create fixed-width and strings columns. | |
| Use the `cudf::empty_like()` to create an empty column from an existing `cudf::column_view`. | |
| Use `cudf::make_empty_column()` to create fixed-width and strings columns. | |
| Use `cudf::empty_like()` to create an empty column from an existing `cudf::column_view`. |
vuule
reviewed
Oct 25, 2024
|
|
||
| The libcudf columns support empty, typed content. These columns have no data and no validity mask. | ||
| Empty strings columns may or may not contain a child offsets column. If is undefined behavior (UB) | ||
| to access the children of an empty strings column. Nested columns like lists and structs may |
There was a problem hiding this comment.
is there any behavior like this in lists columns?
There was a problem hiding this comment.
Do you mean accessing children for an empty lists column?
I think the next sentence describes lists and structs may have children.
There was a problem hiding this comment.
I wondering whether a lists column created with empty_like() always has an offset child column.
There was a problem hiding this comment.
It looks like it does but it would probably be prudent to say accessing it UB as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a section on
Empty Columnsto the libcudf DEVELOPER_GUIDEChecklist