Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compute_global_memory_aggs used by shared memory groupby #17160

Closed

Conversation

PointKernel
Copy link
Member

Description

This work is part of splitting the original bulk shared memory groupby PR #16619.

When the aggregation request requires more shared memory than available and involves dictionary aggregation, we need to perform the aggregation directly in global memory using compute_global_memory_aggs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue non-breaking Non-breaking change labels Oct 23, 2024
@PointKernel PointKernel self-assigned this Oct 23, 2024
@PointKernel
Copy link
Member Author

Just realized this cannot be a standalone PR since it requires the new create_sparse_results_table which will breaks the current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant