Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strings AST vs BINARY_OP benchmarks #17128

Open
wants to merge 25 commits into
base: branch-24.12
Choose a base branch
from

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Oct 18, 2024

Description

This merge request implements benchmarks to compare the strings AST and BINARY_OPs. It also moves out the common string input generator function to a common benchmarks header as it is repeated across other benchmarks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 18, 2024
@lamarrr lamarrr added feature request New feature or request non-breaking Non-breaking change labels Oct 18, 2024
@lamarrr lamarrr marked this pull request as ready for review October 18, 2024 19:26
@lamarrr lamarrr requested a review from a team as a code owner October 18, 2024 19:26
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/common/generate_input.hpp Outdated Show resolved Hide resolved
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/common/generate_input.cu Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/ast/transform.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/common/generate_input.cu Outdated Show resolved Hide resolved
@GregoryKimball
Copy link
Contributor

@davidwendt would you also please take a look?

Copy link

copy-pr-bot bot commented Oct 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants