-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new nvtext minhash_permuted API #16756
Draft
davidwendt
wants to merge
72
commits into
rapidsai:branch-24.12
Choose a base branch
from
davidwendt:perf-minhash-highmem
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add new nvtext minhash_permuted API #16756
davidwendt
wants to merge
72
commits into
rapidsai:branch-24.12
from
davidwendt:perf-minhash-highmem
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Sep 5, 2024
…o perf-minhash-highmem
…o perf-minhash-highmem
3 tasks
davidwendt
changed the title
Improve minhash performance by using more working memory
Add new nvtext minhash_permuted API
Oct 24, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Deprecates the current nvtext minhash functions some of which will be replaced in #16756 with a different signature. The others will no longer be used and removed in future release. The existing gtests and benchmarks will be retained for rework in the future release as well. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #17152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 - In Progress
Currently a work in progress
CMake
CMake build issue
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
pylibcudf
Issues specific to the pylibcudf package
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce new nvtext minhash API that takes a single seed for hashing and 2 parameter vectors to calculate the minhash results from the seed hash:
The
seed
is used to hash theinput
using rolling set of substringswidth
characters wide.The hashes are then combined with the values in
parameter_a
andparameter_b
to calculate a set of 32-bit (or 64-bit) values for each row. Only the minimum value is returned per element ofa
andb
when combined with all the hashes for a row. Each output row is a set of M values whereM = parameter_a.size() = parameter_b.size()
This implementation is significantly faster than the current minhash which computes hashes for multiple seeds.
Included in this PR is also the
minhash64_permuted()
API that is identical but uses 64-bit values for the seed and the parameter values. Also included are new tests and a benchmark as well as the pylibcudf and cudf interfaces.Checklist