Skip to content

Commit

Permalink
Condense comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kingcrimsontianyu committed Oct 22, 2024
1 parent 03830ff commit f54f6cb
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions cpp/src/io/utilities/file_io_utilities.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,9 @@ class cufile_shim {

~cufile_shim()
{
// TODO: This destructor is called after the main function returns. The cuFileDriverClose()
// internally calls CUDA API, resulting in UB (usually manifested as segfault), and therefore
// should not be called here. However, even in the absence of cuFileDriverClose(), cuFile will
// implicitly close the driver, during which process some CUDA calls are still made, likely
// causing segfault. The best way to clean up the resources needs to be revisited in the future.
// TODO: revisit the segfault issue presumably caused by cuFile's implicit driver-close function
// using CUDA API after the main() returns, which constitutes UB.
// https://github.com/rapidsai/cudf/issues/17121
if (cf_lib != nullptr) dlclose(cf_lib);
}

Expand Down

0 comments on commit f54f6cb

Please sign in to comment.