Monkey-patch Readline to fix unresponsiveness on Windows 11 #19571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Oct 18, 2024
lib/msf/ui/console/driver.rb
Outdated
| # Only Windows requires a monkey-patched RbReadline | ||
| return unless Rex::Compat.is_windows | ||
|
|
||
| if defined?(::RbReadline) |
There was a problem hiding this comment.
Suggested change
| if defined?(::RbReadline) | |
| if defined?(::RbReadline) && !defined?(RbReadline::refresh_console_handle) |
I don't think we need to monkey patch this multiple times
|
I think this might have introduced a small performance regression, but it's hard to confirm with my local VM setup being slow to begin with. Will land for now as it fixes the issue which entirely blocks windows 11 users, and we can be smarter about when the refresh happens later 👍 |
adfoster-r7
approved these changes
Oct 18, 2024
Release NotesFixes an issue that stopped users from using navigational arrow keys in msfconsole on newer Windows 11 installs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19294
This PR adds in a Windows-only monkey-patch to RbReadline that forces the console handle to be refreshed to fix an issue where the Windows 11 console would not delete the characters in the console.
Note that the
-L/real-readlineoption remains broken, and applying this patch toReadlinedid not fix it.Verification
msfconsole