Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing guide and Taskfile #219

Merged
merged 14 commits into from
Sep 28, 2024
Merged

Add contributing guide and Taskfile #219

merged 14 commits into from
Sep 28, 2024

Conversation

blackary
Copy link
Collaborator

  • Added CONTRIBUTING.md
  • Separated out linting and testing in github actions
  • Some general code cleanup with new ruff rules
  • Added Taskfile to simplify steps for linting, testing and generating new tests locally

@randyzwitch
Copy link
Owner

@blackary, I merged #217 thinking this PR encapsulated that one's changes. However, now this doesn't pass.

I see in our test requirements, we don't include streamlit 1.34...is that for the #222 reasons or something else? Given that streamlit is 1.38, I wonder if we need to be even more restrictive?

@randyzwitch randyzwitch merged commit 8be280e into master Sep 28, 2024
5 checks passed
@randyzwitch randyzwitch deleted the contributing branch September 28, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants