Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test reset feature in cli tests #997

Merged
merged 2 commits into from
Sep 25, 2023
Merged

ci: test reset feature in cli tests #997

merged 2 commits into from
Sep 25, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Sep 13, 2023 •
edited
Loading

Fix #952

This PR adds a test for the reset feature in the CLI CI.

  • It patches a machine inventory to enable the reset
  • Reset the node
  • Check that the associated machine inventory is deleted
  • Check that the associated machine inventory comes back
  • Check that the cluster is healthy

Verification run

CLI-OBS-Manual-Workflow with k3s and staging ✅
CLI-OBS-Manual-Workflow with k3s and dev ✅

With the system agent fix: https://github.com/rancher/elemental/actions/runs/6278123526/job/17051261008

@juadk juadk self-assigned this Sep 13, 2023
@juadk juadk added the kind/QA label Sep 13, 2023
@juadk juadk force-pushed the 952-add_reset_test_in_cli_tests branch 14 times, most recently from 89c37a1 to e530a28 Compare September 19, 2023 09:59
@juadk juadk force-pushed the 952-add_reset_test_in_cli_tests branch 5 times, most recently from e2dd0fa to cc45f8e Compare September 21, 2023 16:55
@juadk juadk marked this pull request as ready for review September 21, 2023 17:56
@juadk juadk requested a review from a team as a code owner September 21, 2023 17:56
@juadk juadk force-pushed the 952-add_reset_test_in_cli_tests branch from cc45f8e to c70d05d Compare September 22, 2023 07:09
ldevulder
ldevulder requested changes Sep 22, 2023
View reviewed changes
tests/e2e/reset_test.go Show resolved Hide resolved
tests/e2e/reset_test.go Show resolved Hide resolved
tests/e2e/reset_test.go Show resolved Hide resolved
tests/e2e/reset_test.go Show resolved Hide resolved
tests/e2e/suite_test.go Show resolved Hide resolved
@juadk juadk force-pushed the 952-add_reset_test_in_cli_tests branch 5 times, most recently from 3f51b5c to 17a9f68 Compare September 22, 2023 14:06
@juadk juadk force-pushed the 952-add_reset_test_in_cli_tests branch 2 times, most recently from 39a2cda to b3b13cd Compare September 22, 2023 19:01
@juadk juadk force-pushed the 952-add_reset_test_in_cli_tests branch from b3b13cd to cacc5ba Compare September 22, 2023 20:19
ldevulder
ldevulder approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@juadk juadk merged commit d5c18af into main Sep 25, 2023
16 checks passed
@juadk juadk deleted the 952-add_reset_test_in_cli_tests branch September 25, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder approved these changes

Assignees

@juadk juadk

Labels
kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e: add automated tests for reset option
2 participants
@juadk @ldevulder