Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add airgap e2e test (#1034) #1035

Merged
merged 1 commit into from
Jan 19, 2024
Merged

ci: add airgap e2e test (#1034) #1035

merged 1 commit into from
Jan 19, 2024

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Oct 5, 2023 •
edited
Loading

@juadk juadk force-pushed the 1034-automate_airgap_tests branch 30 times, most recently from 3b0d8e2 to aa5d57e Compare October 12, 2023 08:05
@juadk juadk force-pushed the 1034-automate_airgap_tests branch 13 times, most recently from 695d850 to bc6b9bb Compare January 18, 2024 23:04
@juadk juadk marked this pull request as ready for review January 18, 2024 23:48
@juadk juadk requested a review from a team as a code owner January 18, 2024 23:48
@juadk juadk self-assigned this Jan 18, 2024
ldevulder
ldevulder requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somme minor fixes, otherwise very good!!

tests/assets/cluster.yaml Outdated Show resolved Hide resolved
.github/workflows/master-airgap.yaml Outdated Show resolved Hide resolved
.github/workflows/master-airgap.yaml Outdated Show resolved Hide resolved
.github/workflows/master-airgap.yaml Outdated Show resolved Hide resolved
.github/workflows/master-airgap.yaml Outdated Show resolved Hide resolved
tests/scripts/build-airgap Outdated Show resolved Hide resolved
tests/scripts/build-airgap Outdated Show resolved Hide resolved
tests/scripts/build-airgap Outdated Show resolved Hide resolved
tests/scripts/build-airgap Outdated Show resolved Hide resolved
tests/scripts/build-airgap Show resolved Hide resolved
@juadk juadk requested a review from ldevulder January 19, 2024 10:37
ldevulder
ldevulder approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@juadk juadk enabled auto-merge (rebase) January 19, 2024 15:05
@juadk juadk merged commit 9eac079 into main Jan 19, 2024
3 checks passed
@juadk juadk deleted the 1034-automate_airgap_tests branch January 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder approved these changes

Assignees

@juadk juadk

Labels
area/airgap kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e - Automate airgap test in the CI
2 participants
@juadk @ldevulder