Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postinstall: Try harder to retry #7528

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Sep 21, 2024

This re-implements the download retry logic for post-install downloads (lima-alpine images, etc.) so that we can attempt to retry harder when things go wrong (in particular, if we end up going 5 seconds without getting any data). Hopefully this will reduce the chance of us hitting the ten minute timeout.

@mook-as mook-as marked this pull request as draft September 23, 2024 16:27
`Promise.any` will only raise an exception when all of the promises have
rejected (or any promise has resolved); use `Promise.race` instead, where
the first rejecting promise raises.

Signed-off-by: Mark Yen <[email protected]>
This reimplements fetchWithRetry to manually watch the progress of the
download, and if there has been no progress in five seconds, abort the
download and retry.  This will hopefully resolve issues in CI where the
whole download times out after ten minutes because the downloads get stuck.

Signed-off-by: Mark Yen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant