-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSEGOG-349 edit favourite filter #490
Draft
joshuadkitenge
wants to merge
74
commits into
DSEGOG-348-view-favourite-filters
Choose a base branch
from
DSEGOG-349-edit-favourite-filter
base: DSEGOG-348-view-favourite-filters
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DSEGOG-349 edit favourite filter #490
joshuadkitenge
wants to merge
74
commits into
DSEGOG-348-view-favourite-filters
from
DSEGOG-349-edit-favourite-filter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-tests to config
…d add eslint-plugin-jsx-a11y
…int-v9 DSEGOG-344 Upgrade to ESLint v9
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.3 to 5.4.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Update dependency express to v4.21.0
…ite-5.4.6 Bump vite from 5.4.3 to 5.4.6
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.2 to 4.22.4. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.2...v4.22.4) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…t-monorepo Update typescript-eslint monorepo to v8.7.0 (minor)
…ollup-4.22.4 Bump rollup from 4.21.2 to 4.22.4
Update dependency typescript to v5.6.2
Update Yarn to v4.5.0
Update dependency eslint to v9.11.1
…onorepo Update tanstack-query monorepo (minor)
…kfile Update dependency globals to v15.10.0
…onorepo Update tanstack-query monorepo to v5.59.0 (minor)
…action-digest Update codecov/codecov-action digest to b9fd7d1
…gest Update actions/cache digest to 2cdf405
…gest Update actions/cache digest to 3624ceb
…rtifact-digest Update actions/upload-artifact digest to b4b15b8
…-digest Update actions/checkout digest to eef6144
Update dependency @playwright/test to v1.48.0
…x-lockfile Update dependency @eslint/compat to v1.2.0
…t-monorepo Update typescript-eslint monorepo to v8.8.1 (minor)
Update dependency eslint to v9.12.0
…-favourite-filters
joshuadkitenge
force-pushed
the
DSEGOG-348-view-favourite-filters
branch
from
October 15, 2024 15:17
aec7dc6
to
1f90b2b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## DSEGOG-348-view-favourite-filters #490 +/- ##
===================================================================
Coverage 97.89% 97.89%
===================================================================
Files 92 92
Lines 11951 12059 +108
Branches 1887 1397 -490
===================================================================
+ Hits 11699 11805 +106
- Misses 248 252 +4
+ Partials 4 2 -2 ☔ View full report in Codecov by Sentry. |
…-favourite-filter
joshuadkitenge
changed the base branch from
DSEGOG-348-view-favourite-filters
to
develop
October 15, 2024 15:32
joshuadkitenge
changed the base branch from
develop
to
DSEGOG-348-view-favourite-filters
October 15, 2024 15:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A use should be able to edit a filter name or filter. There should be an error message if the user tries to edit a filter withoud chaning the values
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes DSEGOG-349