Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-349 edit favourite filter #490

Draft
wants to merge 74 commits into
base: DSEGOG-348-view-favourite-filters
Choose a base branch
from

Conversation

joshuadkitenge
Copy link
Contributor

Description

A use should be able to edit a filter name or filter. There should be an error message if the user tries to edit a filter withoud chaning the values

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes DSEGOG-349

joelvdavies and others added 30 commits September 6, 2024 08:39
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.3 to 5.4.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.2 to 4.22.4.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…t-monorepo

Update typescript-eslint monorepo to v8.7.0 (minor)
…ollup-4.22.4

Bump rollup from 4.21.2 to 4.22.4
…onorepo

Update tanstack-query monorepo (minor)
renovate bot and others added 25 commits October 4, 2024 18:09
…kfile

Update dependency globals to v15.10.0
…onorepo

Update tanstack-query monorepo to v5.59.0 (minor)
…action-digest

Update codecov/codecov-action digest to b9fd7d1
…gest

Update actions/cache digest to 2cdf405
…gest

Update actions/cache digest to 3624ceb
…rtifact-digest

Update actions/upload-artifact digest to b4b15b8
…-digest

Update actions/checkout digest to eef6144
Update dependency @playwright/test to v1.48.0
…x-lockfile

Update dependency @eslint/compat to v1.2.0
…t-monorepo

Update typescript-eslint monorepo to v8.8.1 (minor)
@joshuadkitenge joshuadkitenge force-pushed the DSEGOG-348-view-favourite-filters branch from aec7dc6 to 1f90b2b Compare October 15, 2024 15:17
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 98.38710% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.89%. Comparing base (1f90b2b) to head (b6c2aa4).

Files with missing lines Patch % Lines
src/api/favouriteFilters.tsx 94.59% 2 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           DSEGOG-348-view-favourite-filters     #490    +/-   ##
===================================================================
  Coverage                              97.89%   97.89%            
===================================================================
  Files                                     92       92            
  Lines                                  11951    12059   +108     
  Branches                                1887     1397   -490     
===================================================================
+ Hits                                   11699    11805   +106     
- Misses                                   248      252     +4     
+ Partials                                   4        2     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge changed the base branch from DSEGOG-348-view-favourite-filters to develop October 15, 2024 15:32
@joshuadkitenge joshuadkitenge changed the base branch from develop to DSEGOG-348-view-favourite-filters October 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants