Add npm script for updating playwright snapshots #279
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #279 +/- ##
========================================
Coverage 95.77% 95.77%
========================================
Files 75 75
Lines 3170 3170
Branches 897 897
========================================
Hits 3036 3036
Misses 132 132
Partials 2 2 ☔ View full report in Codecov by Sentry. |
| "serve:build": "yarn build && serve -l 5001 build", | ||
| "test": "craco test --env=jsdom --coverage --watchAll=false", | ||
| "test:watch": "craco test --env=jsdom --watch", | ||
| "test:playwright": "docker build --tag operations-gateway-playwright-test --file Dockerfile.playwright . && docker run --volume ./playwright-report:/app/playwright-report --publish 9323:9323 operations-gateway-playwright-test", | ||
| "playwright:test": "yarn build:playwright-docker && docker run --env LOCAL_DOCKER=true --volume ./playwright-report:/app/playwright-report --publish 9323:9323 operations-gateway-playwright-test", | ||
| "playwright:update-snapshot": "yarn build:playwright-docker && docker run --env LOCAL_DOCKER=true --volume .:/app --publish 9323:9323 operations-gateway-playwright-test", |
There was a problem hiding this comment.
I tested that this does actually update snapshots - but how does it? I can't see any flags being passed to the playwright command...
There was a problem hiding this comment.
I passed in a different --volume flag for playwright:test and playwright:update-snapshot. Since updated snapshots are written inside the e2e folder, in order to write the changes to e2e/ and playwright-report/ folders to the host file system, I need to mount the entire project folder, hence --volume .:/app.
There was a problem hiding this comment.
Yeah, but doesn't playwright only update snapshots if you provide the -u flag?
There was a problem hiding this comment.
Good question, how did both of us manage to get the snapshots updating without the flag?? I will make another PR to add it back in.
Description
This PR adds an NPM script that can update playwright snapshots.
playwright:update-snapshotis the new scripttest:playwrightis nowplaywright:testyarn playwright testLOCAL_DOCKERis created to denote whether the playwright docker container is run locally.LOCAL_DOCKERto determine which host to serve the report on.Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Hot fix.