Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-129 display user sessions #254

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

joshuadkitenge
Copy link
Contributor

@joshuadkitenge joshuadkitenge commented Jul 4, 2023

Description

  • A user should be able to save a user session and once it's save the session should appear in the drawer (Highlighted). The user should also be able to navigate between session. when a user session is selected it should become highlighted.

Testing instructions

  • Check if it loads a session correctly

  • Check that you can navigate between session without any side effects

  • Check that the list of session updates when a new session is added

  • Review code

  • Check Actions build

  • Review changes to test coverage

  • {more steps here}

Agile board tracking

closes DSEGOG-129

@joshuadkitenge
Copy link
Contributor Author

display a save session

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 95.49% and project coverage change: -0.05% ⚠️

Comparison is base (7821306) 95.77% compared to head (fabda30) 95.72%.
Report is 76 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
- Coverage    95.77%   95.72%   -0.05%     
===========================================
  Files           75       75              
  Lines         3170     3251      +81     
  Branches       897      907      +10     
===========================================
+ Hits          3036     3112      +76     
- Misses         132      137       +5     
  Partials         2        2              
Files Changed Coverage Δ
src/app.types.tsx 100.00% <ø> (ø)
src/search/components/dateTime.component.tsx 80.48% <50.00%> (-1.03%) ⬇️
src/api/sessions.tsx 94.73% <92.00%> (-5.27%) ⬇️
src/session/sessionDrawer.component.tsx 96.29% <95.23%> (-3.71%) ⬇️
src/filtering/filterDialogue.component.tsx 100.00% <100.00%> (ø)
src/search/components/experiment.component.tsx 100.00% <100.00%> (ø)
src/search/components/maxShots.component.tsx 100.00% <100.00%> (ø)
src/search/components/shotNumber.component.tsx 98.07% <100.00%> (+0.07%) ⬆️
src/search/components/timeframe.component.tsx 100.00% <100.00%> (ø)
src/search/searchBar.component.tsx 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from DSEGOG-129-save-sessions to develop August 3, 2023 14:22
@joshuadkitenge
Copy link
Contributor Author

joshuadkitenge commented Aug 3, 2023

  • The animation when changing sessions is inconsistent. I'll create another issue so that can be done in another PR

src/mocks/handlers.ts Outdated Show resolved Hide resolved
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things need addressing: a few minor comments and a bug I noticed when switching to the Plots tab. But otherwise, the functionality seems to be working well :)

Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thought that I had that doesn't necessarily need to be acted on: another way to use the searchParamsUpdated function is to rather than pass it to the underlying search components, instead call it in the "search param update functions" e.g. changeSearchParameterFromDate. Probably makes the components a little simpler as the prop isn't getting passed through, but searchBar gets more complex as we need to create change functions for each parameter where we call searchParamsUpdated as well as the setXParam functions.

@joshuadkitenge joshuadkitenge marked this pull request as ready for review August 8, 2023 13:23
@joshuadkitenge joshuadkitenge merged commit ebfecc3 into develop Aug 8, 2023
4 checks passed
@joshuadkitenge joshuadkitenge deleted the DSEGOG-129-display-user-sessions branch August 8, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants