-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSEGOG-129 display user sessions #254
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #254 +/- ##
===========================================
- Coverage 95.77% 95.72% -0.05%
===========================================
Files 75 75
Lines 3170 3251 +81
Branches 897 907 +10
===========================================
+ Hits 3036 3112 +76
- Misses 132 137 +5
Partials 2 2
☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things need addressing: a few minor comments and a bug I noticed when switching to the Plots tab. But otherwise, the functionality seems to be working well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thought that I had that doesn't necessarily need to be acted on: another way to use the searchParamsUpdated
function is to rather than pass it to the underlying search components, instead call it in the "search param update functions" e.g. changeSearchParameterFromDate
. Probably makes the components a little simpler as the prop isn't getting passed through, but searchBar
gets more complex as we need to create change functions for each parameter where we call searchParamsUpdated
as well as the setXParam
functions.
Description
Testing instructions
Check if it loads a session correctly
Check that you can navigate between session without any side effects
Check that the list of session updates when a new session is added
Review code
Check Actions build
Review changes to test coverage
{more steps here}
Agile board tracking
closes DSEGOG-129