Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds authentication that functions in the same way as
inventory-management-system-api
does. The majority of this code is copied directly from there. Tested with ral-facilities/inventory-management-system#1028.Changes I made here have also been made on ims-api: ral-facilities/inventory-management-system-api#408.
Also had a think about the change to using the
/verify
endpoint instead. The main issue I currently see is handling the e2e tests - we would not be able to run them in the current format without also havingldap-jwt-auth
running/a mock endpoint as we would presumably want all requests to be denied if/verify
is unreachable. I think this needs further investigation & discussion as it will also effect ral-facilities/inventory-management-system-api#399. So I did not attempt to implement this here yet.Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #6