Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mechanism for deactivating users #23

Merged
merged 11 commits into from
Feb 2, 2024

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Jan 24, 2024

Description

This PR modifies the logic for refreshing the access token so that the username in its payload is checked to see if it is part of the active usernames list before it refreshes it.

Testing instructions

Add a set of instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build

Agile board tracking

closes #12

@VKTB VKTB requested a review from joelvdavies January 24, 2024 16:58
@VKTB VKTB requested a review from joelvdavies February 1, 2024 10:25
Base automatically changed from list-of-active-users-#21 to main February 1, 2024 11:56
@VKTB
Copy link
Collaborator Author

VKTB commented Feb 1, 2024

I made some changes so that the env var values used during testing are overridden using pytest.ini instead of using the pytest_configure hook. As such, the tests should now be run with the following command: pytest -c test/pytest.ini test. README was updated accordingly. Please also run pip install .[dev] as pyproject.toml has been updated.

@VKTB VKTB requested a review from joelvdavies February 1, 2024 13:05
@VKTB VKTB merged commit 4c7ff83 into main Feb 2, 2024
2 checks passed
@VKTB VKTB deleted the mechanism-for-deactivating-users-#12 branch February 2, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement mechanism for deactivating users
2 participants