Add a list of active users that can use the system #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvdavies
reviewed
Jan 25, 2024
joelvdavies
reviewed
Jan 25, 2024
VKTB
commented
Feb 1, 2024
joelvdavies
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stores a list of usernames in a text file (
active_usernames.txt) in order to define who can use the system/login. This may have to be changed in future but a file for now would do. It modifies the login logic to check whether the provided username is part of the active username list before attempting to authenticate against the LDAP server.Testing instructions
Add a set of instructions describing how the reviewer should test the code
Agile board tracking
closes #21