Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mock data values, and reorder lifetime field #410

Merged

Conversation

asuresh-code
Copy link
Contributor

Description

Following recent changes in the complementary frontend PR. Main Actions are:

  • changing data rages for expected lifetime field in mock data script
  • changing order of the field in the items Schema/mode/etc, to reflect frontend changes.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

connect to #338

@asuresh-code asuresh-code self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (88ee7ab) to head (71dc1c4).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #410   +/-   ##
========================================
  Coverage    97.87%   97.87%           
========================================
  Files           41       41           
  Lines         1504     1504           
========================================
  Hits          1472     1472           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asuresh-code asuresh-code force-pushed the add-expected-lifetime-field-to-cataolgue-items-#338 branch from dd6213a to 2283278 Compare October 31, 2024 15:59
@asuresh-code asuresh-code force-pushed the add-expected-lifetime-field-to-cataolgue-items-#338 branch from 2283278 to 94a4d58 Compare October 31, 2024 15:59
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for aligning them.

scripts/generate_mock_data.py Outdated Show resolved Hide resolved
inventory_management_system_api/models/catalogue_item.py Outdated Show resolved Hide resolved
@asuresh-code asuresh-code merged commit e5f2e8c into develop Nov 5, 2024
8 checks passed
@asuresh-code asuresh-code deleted the add-expected-lifetime-field-to-cataolgue-items-#338 branch November 5, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants