rename expected_lifetime field #338

[asuresh-code]

Description

Enter a description of the changes here

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage
• {more steps here}

Agile board tracking

connect to #338

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (86211c4) to head (88ee7ab).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #400   +/-   ##
========================================
  Coverage    97.87%   97.87%           
========================================
  Files           41       41           
  Lines         1504     1504           
========================================
  Hits          1472     1472           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelvdavies]

There are still a few mentions of expected_lifetime e.g. in the migration script on line 2, and in the logging. (I used the search tab on vscode to find them). The mock data also needs updating.

[joelvdavies]

LGTM