Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped | Failed -> Rejected. #4

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

CyonAlexRDX
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 99.33775% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.2%. Comparing base (a1d0cdc) to head (20fec99).
Report is 7 commits behind head on migrate_from_other_repo.

Files with missing lines Patch % Lines
...etition_factors_types/neglected_factor_instance.rs 94.1% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           migrate_from_other_repo      #4   +/-   ##
=======================================================
  Coverage                     97.2%   97.2%           
=======================================================
  Files                           37      40    +3     
  Lines                          949     988   +39     
=======================================================
+ Hits                           923     961   +38     
- Misses                          26      27    +1     
Files with missing lines Coverage Δ
src/derivation/collector/key_derivation_outcome.rs 100.0% <ø> (ø)
src/signing/collector/signatures_collector.rs 98.1% <100.0%> (-0.1%) ⬇️
...signing/collector/signing_finish_early_strategy.rs 100.0% <100.0%> (ø)
...ning/interactors/parallel_batch_signing_request.rs 100.0% <ø> (ø)
...igning/interactors/serial_batch_signing_request.rs 100.0% <ø> (ø)
src/signing/petition_types/petition_entity.rs 94.6% <100.0%> (+0.1%) ⬆️
...etition_factors_types/factor_source_referencing.rs 100.0% <100.0%> (ø)
...n_types/petition_factors_types/petition_factors.rs 100.0% <100.0%> (ø)
...s/petition_factors_types/petition_factors_state.rs 100.0% <100.0%> (ø)
...n_factors_types/petition_factors_state_snapshot.rs 100.0% <100.0%> (ø)
... and 9 more

Copy link
Contributor

@Sajjon Sajjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests which asserts array of FAILED neglected factors!

@@ -0,0 +1,19 @@
use crate::prelude::*;

pub trait FactorSourceReferencing: std::hash::Hash + PartialEq + Eq + Clone {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make crate pub?

pub type NeglectedFactorInstance = AbstractNeglectedFactor<HierarchicalDeterministicFactorInstance>;

#[derive(Clone, PartialEq, Eq, Hash)]
pub struct AbstractNeglectedFactor<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc? Crate pub inst of pub?

@@ -147,7 +155,7 @@ mod tests {
FactorSourceIDFromHash::fs0(),
);

sut.did_skip(&factor_instance, false);
sut.skip(&factor_instance, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for failure instead of skip

src/signing/petition_types/petition_of_transaction.rs Outdated Show resolved Hide resolved
@@ -1,36 +1,43 @@
use crate::prelude::*;

#[derive(Clone, PartialEq, Eq, derive_more::Debug)]
pub enum SignWithFactorSourceOrSourcesOutcome {
pub enum SignWithFactorsOutcome {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc?

@CyonAlexRDX CyonAlexRDX merged commit 5340aec into migrate_from_other_repo Aug 29, 2024
5 checks passed
@CyonAlexRDX CyonAlexRDX deleted the neglected branch August 30, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants