-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak: Standardize resource assertion errors #1975
Open
dhedey
wants to merge
2
commits into
develop
Choose a base branch
from
tweak/standardize-assertion-errors
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhedey
force-pushed
the
tweak/standardize-assertion-errors
branch
from
October 25, 2024 03:04
950d185
to
9f2c001
Compare
Docker tags |
Benchmark for cecdf21Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes resource assertion errors across the old assertions and the new assertions and makes some fixes/tweaks:
ASSERT_WORKTOP_CONTAINS
and its cousins, as requested by Les.resource_address
to contextualise constraint failure messages.GeneralResourceAssertionError
to simplify the errors a little and make it easier to match on in a client.swap_remove
during validation of constraints to ensure the selected error is intuitive (i.e. the first erroring id is returned).And a few other misc refactors as part of fixing the tests. (e.g. adding a structural PartialEq to
Decimal
via ensuring these traits are implemented in macros for the Ixxx number types -- this enables it to be used in patterns, e.g. inmatches!
macros in tests).Testing
Existing tests pass (with minor tweaks)