Add some reference related tests #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
Benchmark for 9c775bbClick to view benchmark
|
iamyulong
force-pushed
the
test/threading
branch
from
d554e57
to
30abf24
Compare
iamyulong
force-pushed
the
test/threading
branch
from
30abf24
to
9d93b20
Compare
dhedey
approved these changes
Oct 25, 2024
| }) | ||
| .manifest_builder(|builder| { | ||
| builder | ||
| // Unfortunately, there is no way to grab the received references |
There was a problem hiding this comment.
This test doesn't show whether we can use those references? Can we try doing a vault freeze here perhaps?
Or wait I assume this just-works because it's already in the subintent manifest? So... passing references doesn't do anything really?
Okay cool no worries :)
| @@ -0,0 +1,268 @@ | |||
| use radix_engine_tests::common::PackageLoader; | |||
| use scrypto_test::prelude::*; | |||
|
|
|||
There was a problem hiding this comment.
Might be worth a quick comment at the top explaining that these tests mostly just demonstrate existing behaviour, so we can protect ourselves against future regressions? (rather than being concrete product requirements).
There was a problem hiding this comment.
For sure, to prevent regression and also to make sure relevant code paths are covered.
| use scrypto_test::prelude::*; | ||
|
|
||
| #[test] | ||
| fn can_transfer_locked_bucket_between_threads() { |
There was a problem hiding this comment.
I assume we have a test elsewhere which Josh added which checks we can't transfer a proof between threads? Maybe that should be moved here?
There was a problem hiding this comment.
I assumed so, but didn't find any. Let me just add one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add some reference related tests.