-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some reference related tests #1971
Conversation
Docker tags |
Benchmark for 9c775bbClick to view benchmark
|
d554e57
to
30abf24
Compare
30abf24
to
9d93b20
Compare
}) | ||
.manifest_builder(|builder| { | ||
builder | ||
// Unfortunately, there is no way to grab the received references |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test doesn't show whether we can use those references? Can we try doing a vault freeze here perhaps?
Or wait I assume this just-works because it's already in the subintent manifest? So... passing references doesn't do anything really?
Okay cool no worries :)
@@ -0,0 +1,268 @@ | |||
use radix_engine_tests::common::PackageLoader; | |||
use scrypto_test::prelude::*; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a quick comment at the top explaining that these tests mostly just demonstrate existing behaviour, so we can protect ourselves against future regressions? (rather than being concrete product requirements).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, to prevent regression and also to make sure relevant code paths are covered.
use scrypto_test::prelude::*; | ||
|
||
#[test] | ||
fn can_transfer_locked_bucket_between_threads() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we have a test elsewhere which Josh added which checks we can't transfer a proof between threads? Maybe that should be moved here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed so, but didn't find any. Let me just add one.
Summary
Add some reference related tests.