Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unambiguous metadata value type definitions in OAS #344

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Use unambiguous metadata value type definitions in OAS #344

merged 1 commit into from
Jul 13, 2023

Conversation

krzlabrdx
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-database-migrations:HEAD-30f6c4f

@krzlabrdx krzlabrdx changed the base branch from develop to release/rcnet-v2 July 13, 2023 17:10
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-data-aggregator:HEAD-30f6c4f

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-gateway-api:HEAD-30f6c4f

dhedey
dhedey approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very carefully done. Although looks like something is broken in tests/RadixDlt.NetworkGateway.UnitTests/PostgresIntegration/ScryptoSborUtilsTests.cs

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@krzlabrdx krzlabrdx merged commit c1df2fd into release/rcnet-v2 Jul 13, 2023
11 of 12 checks passed
@krzlabrdx krzlabrdx deleted the ts-sdk-rc2 branch July 13, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhedey dhedey dhedey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzlabrdx @dhedey