fix deposit pre validation for non persisted account. (#795)

radixdlt · Oct 3, 2024 · 1a1134f · 1a1134f
1 parent 5110270
commit 1a1134f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ Release built: _not released yet_
 
 ### Bug fixes
 - Added missing `total_count` property to `/state/validators/list` response.
+- Fix `/transaction/account-deposit-pre-validation` for uninstantiated pre-allocated accounts. It no longer returns error with code 404 `Entity not found`. 
 
 ### API Changes
 - Restored previously removed `total_count` property to `/state/key-value-store/keys` endpoint.

diff --git a/...ateway.PostgresIntegration/Services/AccountDepositSettings/DepositPreValidationQuerier.cs b/...ateway.PostgresIntegration/Services/AccountDepositSettings/DepositPreValidationQuerier.cs
@@ -110,8 +110,25 @@ public DepositPreValidationQuerier(
         CancellationToken token = default
     )
     {
-        var accountEntity = await _entityQuerier.GetNonVirtualEntity<GlobalAccountEntity>(_dbContext, accountAddress, ledgerState, token);
         var xrdResourceAddress = (await _networkConfigurationProvider.GetNetworkConfiguration(token)).WellKnownAddresses.Xrd;
+        var accountEntity = await _entityQuerier.GetEntity<GlobalAccountEntity>(accountAddress, ledgerState, token);
+        if (accountEntity is VirtualAccountComponentEntity)
+        {
+            var resourceItems = resourceAddresses
+                .Select(
+                    resourceAddress => new GatewayModel.AccountDepositPreValidationDecidingFactorsResourceSpecificDetailsItem(
+                        resourceAddress,
+                        false,
+                        resourceAddress == xrdResourceAddress))
+                .ToList();
+
+            return new GatewayModel.AccountDepositPreValidationDecidingFactors(
+                badgeResourceAddress.HasValue ? false : null,
+                AccountDefaultDepositRule.Accept.ToGatewayModel(),
+                resourceItems
+            );
+        }
+
         var addressesToResolve = resourceAddresses.ToList();
         if (badgeResourceAddress.HasValue)
         {