Ensure the user gets no change back. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the amount of XRD that Ignition contributed was equal to the amount of user resources times the price reported by the oracle. This meant that there are cases where the user can get some change back due to the oracle and pool prices being slightly different but within the allowed percentage difference.
We have agreed that we would like the user to get no change back. This PR changes how much XRD is provided for the user's contribution where we always provide the amount of user resources times the price reported by the oracle plus an extra
maximum_allowed_price_difference_percentage% padding on top. This ensures that there is enough XRD to cover the case when additional XRD is required to contribute all of the user assets.