Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several serious bug fixes #506

Merged
merged 33 commits into from
Nov 30, 2018
Merged

Several serious bug fixes #506

merged 33 commits into from
Nov 30, 2018

Commits on Nov 30, 2018

  1. fix some major, glaring bugs, along with removing looping over 

    `filled_data[:]`, which necessitates loading the whole mask cube into
memory
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b98c6d6 View commit details
    Browse the repository at this point in the history

  2. add a warning about memory usage on reproject

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    df7e27e View commit details
    Browse the repository at this point in the history

  3. add @warn_slow on reproject

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    df28afc View commit details
    Browse the repository at this point in the history

  4. add slow warnings, make warn_slow a little better, and add docstring 

    warnings for things that are creating in-memory copies
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    a9a19ec View commit details
    Browse the repository at this point in the history

  5. can't give decorators arguments.

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    2c55753 View commit details
    Browse the repository at this point in the history

  6. need _fill_value in projection init

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    5bd4131 View commit details
    Browse the repository at this point in the history

  7. this breaks a lot of tests, but fixes some small things...

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    4afdbab View commit details
    Browse the repository at this point in the history

  8. try a different way to define data. I don't know why, but this 

    iteration gets a ton of WCS failures
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    42af406 View commit details
    Browse the repository at this point in the history

  9. fixed tests; there were more issues in downsampling. We actually *were* 

    testing the relevant line, we were just testing wrongly.
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    e088c4b View commit details
    Browse the repository at this point in the history

  10. commented-out "fix" to the "view" issue we're encountering in ... 

    matplotlib < 2 only, apparently.
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6234988 View commit details
    Browse the repository at this point in the history

  11. added some more checks and uncommented the 'view' thing, even though 

    it's a hack.  I think we just have to concede incompatilbility with
mpl1.5 now
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    db560df View commit details
    Browse the repository at this point in the history

  12. add documentation and a warning that old versions of mpl fail

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    61a9f4e View commit details
    Browse the repository at this point in the history

  13. skip doctests, add some needed inheritance stuff

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    d9466f0 View commit details
    Browse the repository at this point in the history

  14. minor whitespace change

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    3fed978 View commit details
    Browse the repository at this point in the history

  15. reformat note in BooleanArrayMask.view

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    66eb299 View commit details
    Browse the repository at this point in the history

  16. fix warning formatting

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    624e02a View commit details
    Browse the repository at this point in the history

  17. boost supported mpl version again

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    f51cc7a View commit details
    Browse the repository at this point in the history

  18. try running coverage tests in python 3.7 because there are threads on 

    the internet that claim this was a python-core issue that was (maybe?)
fixed.  However, it is actually impossible for this to be a python issue
alone, it has to be something in py.test also, since we didn't encounter
it at all for years.

pytest-dev/pytest#1217
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    477e590 View commit details
    Browse the repository at this point in the history

  19. try --coverage on a different python version

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b9d9f48 View commit details
    Browse the repository at this point in the history

  20. try changing pytest version

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6754f90 View commit details
    Browse the repository at this point in the history

  21. revert to pytest 3

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    98e7a18 View commit details
    Browse the repository at this point in the history

  22. maybe I can't include a comment there? travis builds still not 

    triggering
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    eeae19f View commit details
    Browse the repository at this point in the history

  23. Add input test for 2D masks

    @e-koch
    e-koch committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6e4b88f View commit details
    Browse the repository at this point in the history

  24. Pass 2D masks when slicing a cube. Bad things happen!!

    @e-koch
    e-koch committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    557af2d View commit details
    Browse the repository at this point in the history

  25. Sort keep axes

    @e-koch
    e-koch committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    a031d2e View commit details
    Browse the repository at this point in the history

  26. drop pytest version further

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    d06f8bd View commit details
    Browse the repository at this point in the history

  27. partial fix for unmatched celestial axes; still failing; wip

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    9d48fcb View commit details
    Browse the repository at this point in the history

  28. fix unmatched celestial issues; I was modifying the original WCS inpl… 

    …ace before, which is bad
    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    e0bd67d View commit details
    Browse the repository at this point in the history

  29. fix wcsutil test

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b36da6d View commit details
    Browse the repository at this point in the history

  30. last attempt to fix the coverage test collection

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    09cc2de View commit details
    Browse the repository at this point in the history

  31. omfg wtf is wrong with having inline comments?!?!?!

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    5070e0c View commit details
    Browse the repository at this point in the history

  32. actual last attempt: try python 3.7 with unrestricted pytest

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    dc3bd9e View commit details
    Browse the repository at this point in the history

  33. disable coverage =(

    @keflavich
    keflavich committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    38e2f2b View commit details
    Browse the repository at this point in the history