Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updating openstack and alerts dashboards with additional checks #535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

the2hill
Copy link
Contributor

@the2hill the2hill commented Nov 4, 2024

No description provided.

Copy link
Contributor

@awfabian-rs awfabian-rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks fine, looks like it introduced a few extraneous spaces?

@@ -4505,11 +4640,11 @@
},
"editorMode": "code",
"exemplar": false,
"expr": "sum(openstack_cinder_limits_volume_used_gb)",
"expr": "sum(openstack_cinder_limits_volume_used_gb) ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous trailing space added?

@@ -4573,11 +4708,11 @@
},
"editorMode": "code",
"exemplar": false,
"expr": "sum(openstack_glance_image_bytes)",
"expr": "sum(openstack_glance_image_bytes) ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous trailing space added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how those got there, came from the export I would assume o.o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants