Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce maxscale #166

Merged
merged 2 commits into from
Mar 22, 2024
Merged

feat: introduce maxscale #166

merged 2 commits into from
Mar 22, 2024

Conversation

cloudnull
Copy link
Contributor

With the release of the mariadb operator v0.25.0 maxscale was introduced to resolve issues with multi-master deployments, enhance scale, and make better use of nodes in the environment. This change creates the maxscale resources and converts our standard deployment systems to use maxscale as the point of ingress.

Specific feature we're interested in

point to an existing MaxScale instance. Doing this will delegate tasks
such as primary failover to MaxScale.

Docs: https://github.com/mariadb-operator/mariadb-operator/blob/main/docs/MAXSCALE.md
Related: https://github.com/mariadb-operator/mariadb-operator/releases/tag/v0.0.26

@cloudnull cloudnull requested a review from sulochan March 20, 2024 01:21
@cloudnull cloudnull marked this pull request as draft March 20, 2024 01:21
Copy link
Collaborator

@sulochan sulochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100

Maybe a bit more info on docs is needed ? Example I can think of that is worth mentioning is that user grants will have to be wildcard. Maybe there are some other cases like this.

Copy link
Contributor

@LukeRepko LukeRepko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudnull cloudnull force-pushed the maxscale branch 2 times, most recently from a824664 to 0bc2613 Compare March 21, 2024 02:07
With the release of the mariadb operator v0.25.0 maxscale was introduced
to resolve issues with multi-master deployments, enhance scale, and make
better use of nodes in the environment. This change creates the maxscale
resources and converts our standard deployment systems to use maxscale
as the point of ingress.

Specific feature we're interested in

> point to an existing MaxScale instance. Doing this will delegate tasks
  such as primary failover to MaxScale.

Docs: https://github.com/mariadb-operator/mariadb-operator/blob/main/docs/MAXSCALE.md
Related: https://github.com/mariadb-operator/mariadb-operator/releases/tag/v0.0.26
Signed-off-by: Kevin Carter <[email protected]>
@cloudnull cloudnull marked this pull request as ready for review March 21, 2024 03:34
@cloudnull
Copy link
Contributor Author

All max scale services have been deployed to the DFW environment and are currently operating normally.

This change resolves issue rackerlabs#165. The change adds the helm annotations
needed to permit helm to retain resouces even in the event of an uninstall.

Resolves: rackerlabs#165
Signed-off-by: Kevin Carter <[email protected]>
@cloudnull cloudnull merged commit 9013dab into rackerlabs:main Mar 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants