POC: Multiple line 409 #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pras7430
reviewed
Jul 6, 2020
| @@ -9,12 +9,12 @@ GEM | |||
| eventmachine (>= 0.12.9) | |||
| http_parser.rb (~> 0.6.0) | |||
| eventmachine (1.2.7) | |||
| ffi (1.12.2) | |||
| ffi (1.13.1) | |||
There was a problem hiding this comment.
hey, we have exclude the gemlock file.
pras7430
reviewed
Jul 6, 2020
src/line-graph.js
Outdated
| connectedCallback() { | ||
| this.innerHTML = `<div style="height: 400px,width:400px" id="container"></div>`; | ||
| var container = document.querySelector(`#container`); | ||
| /*if (this.dataset.lineColor.indexOf(',') > -1) { |
There was a problem hiding this comment.
we can remove it if it is not related to future work
There was a problem hiding this comment.
yup not needed .. removed !
pras7430
approved these changes
Jul 6, 2020
| datapoints.forEach(e => { | ||
| arr.push([new Date(e.time).getTime(), e.value]) | ||
| }) | ||
| return { |
There was a problem hiding this comment.
hey, we can make a separate function and then we can assign the color
There was a problem hiding this comment.
yes.. Created function and add logic inside of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
See ticket here - https://jira.rax.io/browse/MNRVA-409
Description:
Screenshots:
multiline_formatting.gif.zip