Remove save-always usage
#934
Open
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #928
I don't think this is quite right yet but it may be as far as i can take it
When the GitHub team deprecated save-always, they provided some guidance on how to update:
https://github.com/actions/cache/tree/main/save#always-save-cache
The gist is that we have to split our usage into separate explicit save/restore steps.
I am quite uncertain of how to use the magic
always()if conditional, what we want is:inputs.cache = 'always' || inputs.cache = 'true'and the workflow hasn't failed so farinputs.cache = 'always', regardless of whether or not the workflow has failedI tried encoding this using
always()but it feels fishy. I'm not sure ifalways()needs to be at the very beginning of theif:or not. Here are the docs on it:https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#always