v1.5.0 release candidate

[simonpcouch]

Closes #811, closes #807. Two notes:

• I wasn't sure whether to make this release patch or minor, and
• Needs a version bump in DESCRIPTION before submission.

Depending on where the Snowflake migration is at, these may be the first GHA to fail. The offending tests use:

  pwd <- Sys.getenv("ODBC_PWD_SNOWFLAKE")
  if (nchar(pwd) == 0) {
    skip("Secret ODBC_PWD_SNOWFLAKE not available.")
  }

...so will not be an issue on CRAN.

[hadley]

Probably should be a minor release, I think.

[simonpcouch]

You got it. Still needs the DESCRIPTION version bump to 1.5.0 when you submit.

[hadley]

And submitted 😄

[simonpcouch]

Seeing:

   ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure ('test-utils.R:89:3'): set_odbcsysini() works (#791) ────────────────
    identical(Sys.getenv("ODBCSYSINI"), "") is not FALSE

Will try to see if I can reproduce / get some more information out of macbuilder.

[simonpcouch]

mac-builder appears to be down today (possibly as a result of CRAN being down earlier this morning?) and I'm unable to replicate the failures on R-hub. Suggesting that we skip those tests on CRAN for this release.

EDIT: forgot to mention, those R-hub builds are with:

test_that("set_odbcsysini() works (#791)", {
  skip_if(is_windows())

  # expect_false(identical(Sys.getenv("ODBCSYSINI"), ""))
  path <- dirname(odbcListConfig()[["drivers"]])
  Sys.setenv(ODBCSYSINI = path)

  expect_equal(Sys.getenv("ODBCSYSINI"), path)
})

[hadley]

Resubmitted