transition to cli errors #785
Conversation
Merge branch 'main' into cnd-627 # Conflicts: # R/connection-pane.R
| @@ -14,11 +14,10 @@ OdbcConnection <- function( | |||
| timeout = Inf, | |||
| dbms.name = NULL, | |||
| attributes = NULL, | |||
| .connection_string = NULL | |||
| .connection_string = NULL, | |||
| call = caller_env(2) | |||
There was a problem hiding this comment.
Using caller_env(2) as caller_env() shows an unhelpful ".local()" frame:
test_con("SQLITE", attributes = list(boop = "bop"))
#> Error in `.local()`:
#> ! `attributes` does not support the connection attribute "boop".
#> ℹ Allowed connection attribute is "azure_token".with:
3. └─odbc::dbConnect(...)
4. └─odbc (local) .local(drv, ...)
5. └─odbc:::OdbcConnection(...) at odbc/R/dbi-driver.R:184:5
There was a problem hiding this comment.
FWIW, S4 adds the intermediate.local wrapper when the arguments of the generic and the method differ in some way. I think it happens here because our method adds the dsn argument before the docs. (No need to change anything, I just thought you might want to know where this was coming from)
| @@ -14,11 +14,10 @@ OdbcConnection <- function( | |||
| timeout = Inf, | |||
| dbms.name = NULL, | |||
| attributes = NULL, | |||
| .connection_string = NULL | |||
| .connection_string = NULL, | |||
| call = caller_env(2) | |||
There was a problem hiding this comment.
FWIW, S4 adds the intermediate.local wrapper when the arguments of the generic and the method differ in some way. I think it happens here because our method adds the dsn argument before the docs. (No need to change anything, I just thought you might want to know where this was coming from)
| call = call | ||
| ) | ||
| } | ||
| check_exclusive(table, view, .frame = call) |
There was a problem hiding this comment.
SUCH A SATISFYING DIFF
Closes #627.