Skip to content

Commit

Permalink
code-review: Note about mysql driver and NEWS entry
Browse files Browse the repository at this point in the history
  • Loading branch information
detule committed May 18, 2024
1 parent 6887aa2 commit c340595
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/odbc/install-mariadb-driver.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# See #796 for some reasoning behind not using the canned mariadb-odbc-driver (v3.1.15), at time of writing
# and needing to install v3.1.17 from source
sudo apt-get install -y cmake
cd /tmp && git clone https://github.com/MariaDB/mariadb-connector-odbc.git connector
cd connector && git checkout 3.1.17
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# odbc (development version)

* Long running queries can now be interrupted using Ctrl-C. This
feature is enabled by default and can be controlled by the `interruptible`
argument to `dbConnect`, or by the global option `odbc.interruptible`.
Should be considered experimental - if you experience problems please
file an issue on the package github repository (#796)

* Raises "Cancelling previous query" warnings from R rather than from Rcpp when
a connection has a current result to avoid possible incorrect resource
unwinds with `options(warn = 2)` (#797).
Expand Down

0 comments on commit c340595

Please sign in to comment.