Skip to content

Commit

Permalink
address DB2-related NOTEs (#844)
Browse files Browse the repository at this point in the history
* re`document()`
* address `cli_warn()` global variables NOTE
* remove `@inheritParams` that brought in problematic \usage
  • Loading branch information
simonpcouch authored Sep 5, 2024
1 parent b543d3b commit 5f51af7
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Config/Needs/website: tidyverse/tidytemplate
Config/testthat/edition: 3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.0
RoxygenNote: 7.3.2
SystemRequirements: GNU make, An ODBC3 driver manager and drivers.
Collate:
'RcppExports.R'
Expand Down
1 change: 0 additions & 1 deletion R/dbi-table.R
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ setMethod("dbAppendTable", "OdbcConnection",
})

#' @rdname DBI-methods
#' @inheritParams DBI::dbReadTable
#' @export
setMethod("sqlData", "OdbcConnection",
function(con, value, row.names = NA, ...) {
Expand Down
2 changes: 1 addition & 1 deletion R/driver-db2.R
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ setMethod("odbcConnectionTables", c("DB2/AIX64", "character"),
# NULL as colname is not well liked by DB2 it seems. Hack here.
dfTempTables$table_remarks <- NA_character_
}, odbc_database_error = function(e) {
cli_warn("Unable to query for temporary tables in SYSIBMADM.ADMINTEMPTABLES")
cli::cli_warn("Unable to query for temporary tables in SYSIBMADM.ADMINTEMPTABLES")
})
}
rbind(res, dfTempTables)
Expand Down
7 changes: 1 addition & 6 deletions man/DBI-methods.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/DBI-tables.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions man/odbc-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5f51af7

Please sign in to comment.