-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JET.jl
runtest
#61
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 90.07% 90.17% +0.09%
==========================================
Files 18 18
Lines 1692 1699 +7
==========================================
+ Hits 1524 1532 +8
+ Misses 168 167 -1 ☔ View full report in Codecov by Sentry. |
Shall we make code quality tests (including Let's say we call the new group if (GROUP == "All") || (GROUP == "Code Quality")
include(joinpath(testdir, "aqua.jl"))
include(joinpath(testdir, "JET.jl"))
end and remove these two tests from In this case, the CI pipeline can have an independent group which runs this For the action setting file matrix:
... # the original settings for core functionalities
include:
- julia-version: '1'
os: 'ubuntu-latest'
arch: 'x64'
group: 'Code Quality' What do you think ? |
Yes, good idea. I changed the files accordingly. Please check if everything is fine, I'm not an expert on CIs 😄 |
There are some fails on previous Julia versions. It doesn't seem to be related to this PR. |
We can wait a while before they fix this issue. |
For the moment, every runtest imports JET, right? Is there a way to import it only for the Code QUality CIs? Moreover, there is an error in the current CI you just changed. |
Yeah, I was also trying to do this. |
I think the error comes from the |
No now it is fine, you fixed the Code Quality CI error. The errors for previous Julia version doesn't seem to be related to this PR. Anyway, I will probably make a dedicated environment for the code quality tests. |
I mean, the |
There is a compilation error related to only the 1.9 version. It doesn't seem related to this PR, since the error appears even for the main branch. Anyway, I made a separate environment for the code quality tests. What do you think? |
The error for Julia 1.9 relates to |
Modify runtests and CI settings for `JET`
This feature adds
JET.jl
for type instabilities and bugs detection. For the moment it has detected several bugs, that have to be fixed in the future.