Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support general I/O for ProgressBar output #57

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Apr 5, 2024

This PR allows users to output ProgressBar into general I/O, useful for writing logs or even into files.

Summary of this PR:

  • output next!() into general IO (default to stdout)
  • export next!()
  • Improve runtests coverage for ProgressBar
  • change variable name test into core_test in file test/runtest.jl

@ytdHuang ytdHuang added enhancement New feature or request runtests Improvements or additions to runtests labels Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (7cd969c) to head (48e674c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   89.03%   89.87%   +0.84%     
==========================================
  Files          18       18              
  Lines        1660     1660              
==========================================
+ Hits         1478     1492      +14     
+ Misses        182      168      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 0962198 into qutip:main Apr 5, 2024
12 checks passed
@ytdHuang ytdHuang deleted the test/progress_bar branch April 6, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request runtests Improvements or additions to runtests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants