Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump julia-actions/setup-julia from 1 to 2 #52

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 4, 2024

Bumps julia-actions/setup-julia from 1 to 2.

Release notes

Sourced from julia-actions/setup-julia's releases.

v2.0.0 - Update to Node20

What's Changed

Note the rationale for the breaking change was discussed in julia-actions/setup-julia#209

Dependencies and misc

New Contributors

Full Changelog: julia-actions/setup-julia@v1.9.6...v2.0.0

v1.9.6: Fix Apple Silicon installation

What's Changed

Deps & CI

New Contributors

Full Changelog: julia-actions/setup-julia@v1.9.5...v1.9.6

v1.9.5: Maintain mtime of julia build to avoid re-precompilation

A big part of fixing JuliaLang/julia#50667 for julia <1.11 as maintaining the mtime of the julia source files means cached /compiled caches won't be invalidated in new runs where julia has been reinstalled.

What's Changed

Dep updates

... (truncated)

Commits
  • f225878 Add production dependencies & build
  • b96a572 Bump the version number to 2.0.0 in package.json and package-lock.json ...
  • 437a175 update to node20 (#209)
  • e9d953d Bump @​types/node from 20.11.16 to 20.11.30 (#226)
  • 4190528 Bump @​types/semver from 7.5.6 to 7.5.8 (#222)
  • 9acd04f Bump nock from 13.5.1 to 13.5.4 (#224)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [julia-actions/setup-julia](https://github.com/julia-actions/setup-julia) from 1 to 2.
- [Release notes](https://github.com/julia-actions/setup-julia/releases)
- [Commits](julia-actions/setup-julia@v1...v2)

---
updated-dependencies:
- dependency-name: julia-actions/setup-julia
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 4, 2024
@ytdHuang ytdHuang marked this pull request as draft April 4, 2024 05:37
@ytdHuang ytdHuang marked this pull request as ready for review April 4, 2024 05:49
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (31efcf8) to head (62e95db).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          18       18           
  Lines        1661     1661           
=======================================
  Hits         1495     1495           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang
Copy link
Member

ytdHuang commented Apr 4, 2024

@albertomercurio
I also add

- paths-ignore:
  - 'docs/**'

If the changes only come from docs/, it won't run runtests, but will still build documentation.

I'll wait for your approval for this PR. Any comments?

@albertomercurio
Copy link
Member

Ok, cool!

Copy link
Member

@albertomercurio albertomercurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it.

files: lcov.info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these changes? Also the lines above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that if we don't put it in this way, the coverage somehow won't trigger in main branch.

@albertomercurio albertomercurio merged commit 312fbfb into main Apr 4, 2024
14 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/julia-actions/setup-julia-2 branch April 4, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants