Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the constructor of QuantumObject #48

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Apr 1, 2024

fix #46

Also add tests for expected errors in generating QuantumObjects.

@ytdHuang ytdHuang added bug Something isn't working enhancement New feature or request labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (93687f8) to head (31efcf8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   89.74%   90.00%   +0.25%     
==========================================
  Files          17       18       +1     
  Lines        1619     1661      +42     
==========================================
+ Hits         1453     1495      +42     
  Misses        166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@albertomercurio albertomercurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's a better implementation for sure. I'm a bit unsure if in the future we might need tensors instead of just vectors and matrices. But for the moment this is very fine.

@albertomercurio albertomercurio merged commit aebbb1b into qutip:main Apr 3, 2024
12 checks passed
@ytdHuang ytdHuang deleted the fix/QuantumObject branch April 21, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix-type of Ket and Bra
2 participants