-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spell check CI and fix typos #286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes good idea. Do we correct all the spelling in this pr? Or we merge and we fix them in the future ones? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 94.17% 93.64% -0.54%
==========================================
Files 32 32
Lines 2472 2470 -2
==========================================
- Hits 2328 2313 -15
- Misses 144 157 +13 ☔ View full report in Codecov by Sentry. |
albertomercurio
approved these changes
Nov 5, 2024
albertomercurio
pushed a commit
to albertomercurio/QuantumToolbox.jl
that referenced
this pull request
Nov 10, 2024
* add spell check CI * fix version number * fix version number * add typo ignore * fix typos * minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title.
"typos" will check our spelling, tell us where each typo is located, and give us suggestions.
I also add the ignore file for the word:
ket
, since we use it a lot.@albertomercurio
If you agree with this, I will fix all the typos detected by this CI.