Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalize_states option in mcsolve #285

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

albertomercurio
Copy link
Member

Description

As title, this PR will give the possibility to choose wether to normalize the states in mcsolve or not. With true, as default, like in QuTiP.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (2adcd8a) to head (85a6bdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   94.17%   93.64%   -0.54%     
==========================================
  Files          32       32              
  Lines        2472     2470       -2     
==========================================
- Hits         2328     2313      -15     
- Misses        144      157      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/runtests.jl Outdated Show resolved Hide resolved
Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@albertomercurio albertomercurio merged commit 9b23c6f into qutip:main Nov 5, 2024
12 of 14 checks passed
albertomercurio added a commit to albertomercurio/QuantumToolbox.jl that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants