Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace n_traj with ntraj for QuTiP compatibility #243

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

albertomercurio
Copy link
Member

Description

QuTiP uses ntraj as an argument of Monte Carlo and stochastic simulations. Here I change the current argument from n_traj to ntraj, to align to QuTiP syntax.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (bdac5f4) to head (db5d485).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/time_evolution/mcsolve.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          31       31           
  Lines        2268     2268           
=======================================
  Hits         2121     2121           
  Misses        147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ytdHuang ytdHuang merged commit 1913fd9 into qutip:main Sep 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants