Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Translation Content to SwiftUI #628

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Migrate Translation Content to SwiftUI #628

merged 1 commit into from
Feb 3, 2024

Conversation

mohamede1945
Copy link
Collaborator

@mohamede1945 mohamede1945 commented Feb 3, 2024

This commit also removes the dependency on the Texture 3rd party library. In addition to some minor refactoring. Complete list of changes here:

  • Migrate Page Translation Content to SwiftUI.
  • Migrate Verse Translation to Swiftui.
  • Translation UI updated to match the old UI and Android version.
  • Using 1421 Madina mushaf's sura name decoration in translation view.
  • Showing Footnotes as number similar to Android. Tapping the number opens a sheet with the footnote content.
  • "Read more" is now on its own line to make it easy to find.
  • Tapping only the read more expands the text instead of the whole cell.
  • No "Read less" functionality.
  • Chunking translation text for performance. Chunk size=800 characters.
  • Logger's label renamed from default to quran-ios.
  • Schemes version upgraded to Xcode 15.1.
  • Deprecating few of the QuranTextDataService to remove the dependency on LocalTranslationsRetriever.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (5547188) 40.42% compared to head (4b0a70b) 40.60%.

Files Patch % Lines
...vice/Sources/SelectedTranslationsPreferences.swift 42.85% 8 Missing ⚠️
Core/Utilities/Sources/Features/Pair.swift 0.00% 3 Missing ⚠️
...Sources/TranslationText/QuranTextDataService.swift 40.00% 3 Missing ⚠️
...omain/AnnotationsService/Sources/NoteService.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   40.42%   40.60%   +0.18%     
==========================================
  Files         520      518       -2     
  Lines       21072    20977      -95     
==========================================
  Hits         8518     8518              
+ Misses      12554    12459      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit bcc4d69 into main Feb 3, 2024
2 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch February 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant